[FL-3488] Assign tickets to all TODO items (#2988)

Co-authored-by: あく <alleteam@gmail.com>
This commit is contained in:
Astra
2023-08-23 02:56:27 +09:00
committed by GitHub
co-authored by あく
parent 200c44bdca
commit e353433cd8
66 changed files with 85 additions and 92 deletions
+1 -1
View File
@@ -22,7 +22,7 @@ void subghz_device_registry_init(void) {
SUBGHZ_RADIO_DEVICE_PLUGIN_API_VERSION,
firmware_api_interface);
//ToDo: fix path to plugins
//TODO FL-3556: fix path to plugins
if(plugin_manager_load_all(subghz_device->manager, "/any/apps_data/subghz/plugins") !=
//if(plugin_manager_load_all(subghz_device->manager, APP_DATA_PATH("plugins")) !=
PluginManagerErrorNone) {
+2 -2
View File
@@ -744,7 +744,7 @@ static bool
bin_raw_debug("\r\n\r\n");
#endif
//todo can be optimized
//TODO FL-3557: can be optimized
BinRAW_Markup markup_temp[BIN_RAW_MAX_MARKUP_COUNT];
memcpy(
markup_temp,
@@ -770,7 +770,7 @@ static bool
}
}
}
//todo can be optimized
//TODO FL-3557: can be optimized
if(bin_raw_type == BinRAWTypeGap) {
if(data_temp != 0) { //there are sequences with the same number of bits
+3 -3
View File
@@ -122,7 +122,7 @@ static bool subghz_protocol_keeloq_gen_data(SubGhzProtocolEncoderKeeloq* instanc
uint32_t fix = (uint32_t)btn << 28 | instance->generic.serial;
uint32_t decrypt = (uint32_t)btn << 28 |
(instance->generic.serial & 0x3FF)
<< 16 | //ToDo in some protocols the discriminator is 0
<< 16 | //TODO FL-3558: in some protocols the discriminator is 0
instance->generic.cnt;
uint32_t hop = 0;
uint64_t man = 0;
@@ -149,7 +149,7 @@ static bool subghz_protocol_keeloq_gen_data(SubGhzProtocolEncoderKeeloq* instanc
hop = subghz_protocol_keeloq_common_encrypt(decrypt, man);
break;
case KEELOQ_LEARNING_UNKNOWN:
hop = 0; //todo
hop = 0; //TODO FL-3559
break;
}
break;
@@ -200,7 +200,7 @@ static bool
//gen new key
if(subghz_protocol_keeloq_gen_data(instance, btn)) {
//ToDo if you need to add a callback to automatically update the data on the display
//TODO FL-3560: if you need to add a callback to automatically update the data on the display
} else {
return false;
}
+1 -2
View File
@@ -265,7 +265,7 @@ SubGhzProtocolStatus
furi_assert(context);
UNUSED(context);
UNUSED(flipper_format);
//ToDo stub, for backwards compatibility
// stub, for backwards compatibility
return SubGhzProtocolStatusOk;
}
@@ -273,7 +273,6 @@ void subghz_protocol_decoder_raw_get_string(void* context, FuriString* output) {
furi_assert(context);
//SubGhzProtocolDecoderRAW* instance = context;
UNUSED(context);
//ToDo no use
furi_string_cat_printf(output, "RAW Date");
}
+1 -1
View File
@@ -380,7 +380,7 @@ static void subghz_protocol_secplus_v2_encode(SubGhzProtocolEncoderSecPlus_v2* i
uint8_t roll_2[9] = {0};
instance->generic.cnt++;
//ToDo it is not known what value the counter starts
//TODO Fl-3548: it is not known what value the counter starts
if(instance->generic.cnt > 0xFFFFFFF) instance->generic.cnt = 0xE500000;
uint32_t rolling = subghz_protocol_blocks_reverse_key(instance->generic.cnt, 28);
+1 -1
View File
@@ -344,7 +344,7 @@ void subghz_setting_load(SubGhzSetting* instance, const char* file_path) {
}
while(flipper_format_read_uint32(
fff_data_file, "Frequency", (uint32_t*)&temp_data32, 1)) {
//Todo: add a frequency support check depending on the selected radio device
//Todo FL-3535: add a frequency support check depending on the selected radio device
if(furi_hal_subghz_is_frequency_valid(temp_data32)) {
FURI_LOG_I(TAG, "Frequency loaded %lu", temp_data32);
FrequencyList_push_back(instance->frequencies, temp_data32);
+3 -3
View File
@@ -165,7 +165,7 @@ static int32_t subghz_tx_rx_worker_thread(void* context) {
SUBGHZ_TXRX_WORKER_TIMEOUT_READ_WRITE_BUF);
subghz_tx_rx_worker_tx(instance, data, SUBGHZ_TXRX_WORKER_MAX_TXRX_SIZE);
} else {
//todo checking that he managed to write all the data to the TX buffer
//TODO FL-3554: checking that it managed to write all the data to the TX buffer
furi_stream_buffer_receive(
instance->stream_tx, &data, size_tx, SUBGHZ_TXRX_WORKER_TIMEOUT_READ_WRITE_BUF);
subghz_tx_rx_worker_tx(instance, data, size_tx);
@@ -178,7 +178,7 @@ static int32_t subghz_tx_rx_worker_thread(void* context) {
furi_stream_buffer_bytes_available(instance->stream_rx) == 0) {
callback_rx = true;
}
//todo checking that he managed to write all the data to the RX buffer
//TODO FL-3554: checking that it managed to write all the data to the RX buffer
furi_stream_buffer_send(
instance->stream_rx,
&data,
@@ -189,7 +189,7 @@ static int32_t subghz_tx_rx_worker_thread(void* context) {
callback_rx = false;
}
} else {
//todo RX buffer overflow
//TODO FL-3555: RX buffer overflow
}
}
}